seal: Fix issue migrating from Auto->Shamir and improve tests#9430
Merged
Conversation
alexanderbez
approved these changes
Jul 9, 2020
alexanderbez
suggested changes
Jul 9, 2020
Contributor
alexanderbez
left a comment
alexanderbez
left a comment
There was a problem hiding this comment.
Looks like there's a nil pointer dereference issue from a test.
vishalnayak
approved these changes
Jul 9, 2020
added 2 commits
July 9, 2020 09:29
briankassouf
added a commit
that referenced
this pull request
Jul 9, 2020
* Fix issue migrating from Auto->Shamir and improve tests * Undo newline * fix panic in test * Fix test panic
briankassouf
added a commit
that referenced
this pull request
Jul 9, 2020
andaley
pushed a commit
that referenced
this pull request
Jul 17, 2020
* Fix issue migrating from Auto->Shamir and improve tests * Undo newline * fix panic in test * Fix test panic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.