Ui/fix ui tests#9438
Merged
Merged
Conversation
chelshaw
approved these changes
Jul 9, 2020
andaley
pushed a commit
that referenced
this pull request
Jul 9, 2020
* fix linting errors * don't show primary url if we don't have any primaries * Revert "fix linting errors" This reverts commit a56d371. * run all component tests always
andaley
pushed a commit
that referenced
this pull request
Jul 9, 2020
andaley
pushed a commit
that referenced
this pull request
Jul 17, 2020
* fix linting errors * don't show primary url if we don't have any primaries * Revert "fix linting errors" This reverts commit a56d371. * run all component tests always
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes these failing tests, which were failing because they were trying to check the length on an array of primaries when one didn't exist. Not all secondaries will have an array of primaries, so this is expected, we just had to account for it.