Add truthy check for data.policies before calling 'includes' on it#9467
Merged
Conversation
Monkeychip
approved these changes
Jul 13, 2020
Contributor
Monkeychip
left a comment
Monkeychip
left a comment
There was a problem hiding this comment.
My only thought is to see if the person reporting the issue can test on this branch to see if it fixes their issue. However, that's likely not an option. Regardless, this fix appears to be harmless even if it does not fix the issue as all you're doing is catching null on data.policies where before we were not.
andaley
approved these changes
Jul 13, 2020
chelshaw
added a commit
that referenced
this pull request
Jul 13, 2020
chelshaw
added a commit
that referenced
this pull request
Jul 13, 2020
chelshaw
added a commit
that referenced
this pull request
Jul 13, 2020
pull Bot
pushed a commit
to Zezo-Ai/vault
that referenced
this pull request
Sep 19, 2025
…#9467) * adding new locks * adding initial testing * changelog * Update changelog/_9336.txt * fixing test to use proper error output * added additional locks on pops and last push. * fixing tests since I cant use t.Fatalf in a go func * adding rotation window, removing lock as reached a deadlock in test * removing locking from the OnFailure * removing unused locks. --------- Co-authored-by: JMGoldsmith <spartanaudio@gmail.com> Co-authored-by: John-Michael Faircloth <fairclothjm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix issue #9179 but unfortunately I haven't been able to replicate the same behavior, before or after the fix.
Should be backported to the next 1.4.x release. Still looking into what could be causing the root issue (
policiesis saved as null) and open to other ways this could be addressed