Get rid of sdk internal reloadutil package for now.#9515
Merged
Conversation
Contributor
|
I'm a bit confused why the internal package can't be used by |
calvn
approved these changes
Jul 17, 2020
Contributor
calvn
left a comment
calvn
left a comment
There was a problem hiding this comment.
I dug a bit more into this but couldn't pinpoint an exact answer as to why this is happening aside from it being a possible vendoring conflict. It could be related to golang/go#34558, but let's accept this in the meantime to get around the test run failure.
jefferai
added a commit
that referenced
this pull request
Jul 17, 2020
jefferai
added a commit
that referenced
this pull request
Jul 17, 2020
jefferai
added a commit
that referenced
this pull request
Jul 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivated by this failure: https://circleci.hashicorp.engineering/gh/hashicorp/vault-enterprise/42316#tests/containers/1