Conversation
Collaborator
|
Why such a modest increase? I didn't look very closely, but I didn't see any behaviour in these tests that rely on it being a short expiry. TestExpiration_RenewToken seems similar in spirit to TestExpiration_Renew and it uses an hour. I would go up to at least |
Collaborator
Author
|
Sure, can do. I just assumed that if this was a rarely failing test, this would make it 2.5x less likely. But happy to increase further since that doesn't actually slow the test. |
…or irrelevant, back to 20ms if they are
ncabatoff
approved these changes
Jul 28, 2020
sapk
pushed a commit
to sapk-fork/vault
that referenced
this pull request
Oct 6, 2025
…shicorp#9600) (hashicorp#9758) Co-authored-by: Bianca <48203644+biazmoreira@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NoopBackend is primed with a canned Response for many of the unit tests
in expiration_test.go. If on a slow machine a lease expires, the revocation
will trigger a request to the backend, which may race on the population
of the same Response instance being used by the unit test.