Skip to content

Backport 1.5.1: pki: use revocationInfo.RevocationTimeUTC when revoking certs with ti…#9644

Merged
calvn merged 1 commit into
release/1.5.xfrom
backport-pr-9609-1.5.x
Aug 7, 2020
Merged

Backport 1.5.1: pki: use revocationInfo.RevocationTimeUTC when revoking certs with ti…#9644
calvn merged 1 commit into
release/1.5.xfrom
backport-pr-9609-1.5.x

Conversation

@calvn
Copy link
Copy Markdown
Contributor

@calvn calvn commented Jul 30, 2020

…… (#9609)

  • pki: use revocationInfo.RevocationTimeUTC when revoking certs with tidy_revoked_certs set to true

  • update comment

  • tidy: use same time snapshot for OR comparison

#9609)

* pki: use revocationInfo.RevocationTimeUTC when revoking certs with tidy_revoked_certs set to true

* update comment

* tidy: use same time snapshot for OR comparison
@calvn calvn added this to the 1.5.1 milestone Jul 30, 2020
@calvn calvn requested a review from a team August 7, 2020 00:20
Copy link
Copy Markdown
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the CI failures look unrelated. Though perhaps worth fixing the title to include the PR number for ease of reading when people are looking back at single-line commit messages in the logs.

@calvn calvn merged commit 2501e6b into release/1.5.x Aug 7, 2020
@calvn calvn deleted the backport-pr-9609-1.5.x branch August 7, 2020 19:24
pull Bot pushed a commit to Zezo-Ai/vault that referenced this pull request Sep 25, 2025
…hicorp#9647)

Co-authored-by: John-Michael Faircloth <fairclothjm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants