Skip to content

Bundle couchbase database plugin with vault#9664

Merged
tomhjp merged 5 commits into
masterfrom
bundle-couchbase-database-plugin
Aug 7, 2020
Merged

Bundle couchbase database plugin with vault#9664
tomhjp merged 5 commits into
masterfrom
bundle-couchbase-database-plugin

Conversation

@tomhjp
Copy link
Copy Markdown
Contributor

@tomhjp tomhjp commented Aug 5, 2020

The couchbase database plugin is a new secrets backend allowing vault to manage dynamic and static roles for instances of couchbase database. See the repo here for full details.

This PR bundles the new plugin into the vault binary, as we do with most other database plugins.

  • Import plugin to the registry
  • Add it to the gen_openapi.sh script
  • go mod tidy and go mod vendor

I've also built vault from this PR and tested that I can enable and run the couchbase plugin:

tom:~ $ vault secrets enable database
Success! Enabled the database secrets engine at: database/
tom:~ $ vault write database/config/insecure-couchbase plugin_name=couchbase-database-plugin hosts=localhost username=Administrator password=password allowed_roles="*"
tom:~ $ vault write database/roles/insecure-couchbase-admin-role db_name=insecure-couchbase default_ttl=5m max_ttl=1h
Success! Data written to: database/roles/insecure-couchbase-admin-role
tom:~ $ vault read database/creds/insecure-couchbase-admin-role
Key                Value
---                -----
lease_id           database/creds/insecure-couchbase-admin-role/rgZP9Yk0jBuxTk5eawTpC9b3
lease_duration     5m
lease_renewable    true
password           A1a-ab2HuBC379yLslIk
username           v-root-insecure-couchbase-admin-role-1bdK1jAy4vbOR

@tomhjp tomhjp requested a review from jasonodonnell August 5, 2020 11:06
@tomhjp tomhjp requested review from Valarissa, calvn and catsby August 5, 2020 15:53
Comment thread go.mod Outdated
Copy link
Copy Markdown
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending using the right tag for the plugin.

@tomhjp
Copy link
Copy Markdown
Contributor Author

tomhjp commented Aug 6, 2020

LGTM pending using the right tag for the plugin.

Good point, done.

@jasonodonnell jasonodonnell self-requested a review August 6, 2020 19:51
@tomhjp tomhjp merged commit d8995bf into master Aug 7, 2020
@tomhjp tomhjp deleted the bundle-couchbase-database-plugin branch August 7, 2020 10:01
eualin pushed a commit to eualin/vault that referenced this pull request Sep 26, 2025
…corp#9664) (hashicorp#9683)

* actions: use self-hosted runners in hashicorp/vault

While it is recommended that we use self-hosted runners for every
workflow in private and internal accounts, this change was primarily
motivated by different runner types using different cache paths. By
using the same runner type everywhere we can avoid double caches of the
internal Vault tools.

* disable the terraform wrapper in ci-bootstrap to handle updated action

Signed-off-by: Ryan Cragun <me@ryan.ec>
Co-authored-by: Ryan Cragun <me@ryan.ec>
anwittin pushed a commit that referenced this pull request Sep 29, 2025
#9687) (#9690)

* actions: use self-hosted runners in hashicorp/vault

While it is recommended that we use self-hosted runners for every
workflow in private and internal accounts, this change was primarily
motivated by different runner types using different cache paths. By
using the same runner type everywhere we can avoid double caches of the
internal Vault tools.

* disable the terraform wrapper in ci-bootstrap to handle updated action

Signed-off-by: Ryan Cragun <me@ryan.ec>
Co-authored-by: Ryan Cragun <me@ryan.ec>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants