Ui/transform sidebranch#9665
Merged
Merged
Conversation
* Show Transform on engines list if enterprise * Add box-radio component * Add is-disabled styling for box-radio and fix tooltip styling when position: above * Add KMIP and Transform to possible features on has feature helper
* WIP // list transforms, console.logs and all * setup LIST transformations ajax request and draft out options-for-backend options * change from plural to singluar and add transform to secret-edit * create two transform edit components * modify transform model with new attrs * add adapterFor to connect transform adapter to transform-edit-form component * setup Allowed roles searchSelect component to search over new transform/role adapter and model. * clean up for PR * clean up linting errors * restructure adapter call, now it works. * remove console * setup template model for SearchSelect component * add props to form field and search select for styling Co-authored-by: Chelsea Shaw <chelshaw.dev@gmail.com>
* Update casing and wording on Transform list route. Use generic list item for transformations * Add back js file for transformation-edit * Set up transform for tabs
* add conditional for masking vs tweak source based on type, and update text for create transformation * change order * fix error with stringArray * setup the edit/delete transformation view * clean up toolbar links * setup serializer to change response of mask character from keycode to character * change styling of label and sub-text size, confirmed with design * temp fix on templates vs template * add clickable list item * add space between template list * setup styling and structure for the rest of the show transformation. TODO: turn into components. * create transform-show-transformation component * add attachCapabilities to transform model and update transform-transformation-itme list accordingly * clean up liniting errors * address pr comments * remove leftover * clean up
* clean up some of the TODOs * setup edit view with read only attributes for name and template * setup initial selected for search select component * fixes * hide templates form field for now * set selectLimit for search select component * hide power select if the select limit is greater than or equal to the selectedOptions length * clean up failing linting * address pr comments
* Update search-select to pass backend to query if exists * Update role and template adapters * cleanup * Fix replace with static string
* amend encode/decode commands for now until design gets back with more details * restrict character count on masking input field * clean up selectLimit * show backend instead of transform in cli copy command
andaley
reviewed
Aug 21, 2020
Contributor
andaley
left a comment
andaley
left a comment
There was a problem hiding this comment.
this is looking great! all of the comments/questions i had are non-blocking. one suggestion to make this PR more robust would be to add an acceptance test to ensure that all of the critical workflows (i.e. creating / editing a transform) work end to end.
nice work! 🤠
| <form onsubmit={{action "createOrUpdate" "create"}}> | ||
| <div class="box is-sideless is-fullwidth is-marginless"> | ||
| {{message-error model=model}} | ||
| {{!-- TODO: figure out what this ?? --}} |
Contributor
There was a problem hiding this comment.
ah, this might be a reminder that editing something here only applies to your namespace? that's my wild guess, at least
| > | ||
| {{#if (eq mode 'create')}} | ||
| Create transformation | ||
| {{else if (eq mode 'edit')}} |
Contributor
There was a problem hiding this comment.
if this is the edit form, why/when would the mode be create? and similarly, why would the TransformCreateForm's mode ever be edit?
Contributor
Author
There was a problem hiding this comment.
This is a case of unfortunate naming in the secrets engine space. The component name for show/create/edit is saved as editComponent in options-for-backend, and we're following the rest of the naming conventions here. I can see the value of keeping it consistent with the others, as well as the value of naming it something more specific like transform-show-create-edit.hbs (although that's quite verbose) 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial work for the Transform Secret Engine, which includes:
Enable (with ADP module)
Enable (without ADP module
Empty view of transformations
Create transformation
List transformations
Edit transformation
