Update OpenLDAP secrets plugin 0.1.4 -> 0.1.5#9673
Merged
Conversation
jasonodonnell
approved these changes
Aug 6, 2020
Contributor
jasonodonnell
left a comment
There was a problem hiding this comment.
LGTM. The race condition failure seems suspicious, wondering if this is already known?
calvn
suggested changes
Aug 6, 2020
d573dff to
7a6bac9
Compare
Contributor
Author
|
Thanks @calvn - I've dropped the previous commit, rebased and done as suggested (without the |
calvn
approved these changes
Aug 7, 2020
tomhjp
added a commit
that referenced
this pull request
Aug 17, 2020
tomhjp
added a commit
that referenced
this pull request
Aug 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the OpenLDAP secrets plugin to v0.1.5, which includes a new
adschema for managing AD instances. See hashicorp/vault-plugin-secrets-openldap#16 for the feature PR, and #9619 for the docs PR.Upgrade was performed via: