Skip to content

UI - Secrets KV2 Added Created Time to view secret. Resolves: #6215#9800

Closed
aphorise wants to merge 1 commit into
hashicorp:mainfrom
aphorise:ui-kv-creation-date-show
Closed

UI - Secrets KV2 Added Created Time to view secret. Resolves: #6215#9800
aphorise wants to merge 1 commit into
hashicorp:mainfrom
aphorise:ui-kv-creation-date-show

Conversation

@aphorise
Copy link
Copy Markdown
Contributor

@aphorise aphorise commented Aug 22, 2020

Provided new feature for showing creation time as part of KV2 secrets engine as requested on GH-Issue: #6215

PS - advance apologies for missing tests - kindly help with my inadequacies there.

ui_kv_created_time

@aphorise aphorise requested a review from chelshaw September 18, 2020 14:00
@arnouthoebreckx
Copy link
Copy Markdown

@aphorise Would it be possible to get something like this merged? It would be a great change.

@ivana-mcconnell
Copy link
Copy Markdown

Hey @aphorise ! Thanks for the PR, we really appreciate you trying to contribute to the UI. We're not going to merge this PR right now, however— it involves visual design work that has not been prioritized, and the tests are not passing. To help you be more successful in the future, the UI team has a particular process that we follow, and we do outline it in the Contribution Guide here. That said, we hear that this is useful and do hope to look at the KV secrets engine in the near future and incorporate customer requests as part of improving it.

tsaarni pushed a commit to Nordix/vault that referenced this pull request Oct 23, 2025
…t Vault glob semantics (+, deny precedence) into ce/main (hashicorp#9800) (hashicorp#10121)

* UI Fix: UI permissions banner and side bar nav gating respect Vault glob semantics (+, deny precedence) (hashicorp#9522)

* add in empty states when no permissions error but no list values found.

* wip

* wip cont.

* a lot closer... I think

* looking good, now to smoke test (Again)

* welp revert fix to adapter that borked it.

* add changelog

* test coverage—a lot

* fix some issues with root vs fallback show sidebar nav

* address pr comments and clean up comments and left over duplicate methods in permission service

* Apply suggestion from @hellobontempo



* add resultant-acl in canary paths

* remove from canary and use capability check instead inside permissionsBanner

* clean up

* fix merge things

---------



* add conditional for enterprise vs ce

---------

Co-authored-by: Vault Automation <github-team-secure-vault-core@hashicorp.com>
Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants