Backport 1.5: Disable usage metrics on performance standby nodes. (#9966)#9967
Merged
Conversation
ncabatoff
reviewed
Sep 18, 2020
| if c.expiration != nil { | ||
|
|
||
| // Emit on active node only | ||
| if c.expiration != nil && !c.perfStandby { |
Collaborator
There was a problem hiding this comment.
Suggest c.PerfStandby() instead for locking.
Contributor
Author
There was a problem hiding this comment.
I think that some care is needed because c.stateLock can be held while acquiring c.metricsLock, so we shouldn't acquire them in the reverse order here.
ncabatoff
reviewed
Sep 18, 2020
| c.stateLock.RUnlock() | ||
| case <-identityCountTimer: | ||
| // Only emit on active node | ||
| if c.perfStandby { |
ncabatoff
changed the title
ncabatoff
approved these changes
Sep 22, 2020
pull Bot
pushed a commit
to NOUIY/vault
that referenced
this pull request
Oct 22, 2025
* replace instances of ToolTip component with HDS tooltip * Replace InfoTooltip component instances with HDS tooltip * update tests * remove remaining custom tooltip code * remove rich tooltip with copy * update test and update toolbar link with styling to remove extra link * Apply suggestions from code review * update test and remove setRunOptions now that tooltip violations are addressed * Revert "Apply suggestions from code review" This reverts commit 90f01c653be68f23b6dbd75f252d227e38dbe53f. * Remove unused disabled tooltip code * add comment and TODO explaining conditional modifier pattern --------- Co-authored-by: lane-wetmore <lane.wetmore@hashicorp.com> Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.