Skip to content

Update k8s auth docs for new parameter#9992

Merged
tvoran merged 8 commits into
masterfrom
docs/VAULT-629/update-k8s-auth
Sep 25, 2020
Merged

Update k8s auth docs for new parameter#9992
tvoran merged 8 commits into
masterfrom
docs/VAULT-629/update-k8s-auth

Conversation

@tvoran
Copy link
Copy Markdown
Member

@tvoran tvoran commented Sep 18, 2020

Adds info about the disable_local_ca_jwt parameter added in hashicorp/vault-plugin-auth-kubernetes#97

To be deployed with 1.5.4.

Copy link
Copy Markdown
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a suggestion and ask a clarifying question. I believed we discussed this last week so please forgive me if I'm asking you to repeat yourself, I just remember this slightly differently than the documentation says here

Comment thread website/pages/api-docs/auth/kubernetes/index.mdx Outdated
If they aren't specified, Vault will use the local CA cert and service account
JWT for the `kubernetes_ca_cert` and `token_reviewer_jwt` parameters,
respectively, when running in a Kubernetes pod. This behavior may be disabled by
setting `disable_local_ca_jwt` to `true`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If users set this to true do they then also need to specify kubernetes_ca_cert and token_reviewer_jwt as well?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they set disable_local_ca_jwt to true, then either kubernetes_ca_cert or pem_keys needs to be specified as well. token_reviewer_jwt is optional.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it helped, but I tried to elaborate a little more in 7fe90f0.

@tvoran tvoran requested a review from a team September 24, 2020 05:55

### Caveats

Either `kubernetes_ca_cert` or `pem_keys` must be set.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dependent on the value from disable_local_ca_jwt?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, tried to clarify in 6588f33 and e6d098f.

@tvoran tvoran merged commit 0747fa1 into master Sep 25, 2020
@tvoran tvoran deleted the docs/VAULT-629/update-k8s-auth branch September 25, 2020 18:17
github-actions Bot pushed a commit that referenced this pull request Sep 25, 2020
Adds info about the disable_local_ca_jwt parameter.

Co-authored-by: Clint <catsby@users.noreply.github.com>
tsaarni pushed a commit to Nordix/vault that referenced this pull request Oct 23, 2025
…) (hashicorp#9993)

* go: bump .go-version to 1.25.2
* go: handle changes to net/url parsing enforcement in Go 1.25.2

    The fixes for CVE-2025-47912 (https://go.dev/issue/75678) change
    behavior when parsing invalid IPv4 addresses. Update the test to
    for these changes.

Signed-off-by: Ryan Cragun <me@ryan.ec>
Co-authored-by: Ryan Cragun <me@ryan.ec>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants