-
Notifications
You must be signed in to change notification settings - Fork 38
Fix repetition of :out-dir when perun processes a file more than once #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ok cool so I will test this out against the current working site I have and report back |
|
So I checked this and now with the following: (def posts-dir "blog/posts")
(perun/render :out-dir posts-dir :renderer 'com.andrearichiardi.blog.post/render-page)I get: target/
├── blog
│ └── posts
│ └── public
│ ├── cljs-on-gh-pages.html
│ ├── cljs-replumb-require.html
│ ├── replumb-ast.html
│ └── semantic-perun-blog.html
└── public
├── blog
...While before it was correctly under |
|
Uhm, but now if I move the posts to |
| (let [content (slurp (boot/tmp-file (boot/tmp-get fileset path))) | ||
| path-args (if (= out-dir (:out-dir options)) ;; if custom out-dir we cannot rely on pre-built :path | ||
| [path] | ||
| [out-dir (:out-dir options) filename]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lines seems to me to build the path that would work for me, public before the specified :out-dir.
|
So ok, I finally settled with another solution, blog posts are in (perun/render :renderer 'com.andrearichiardi.blog.post/render-page) |
|
It would be great to merge this one as well and maybe deploy a |
@arichiardi I think that this applies pretty much the same fix you merged in #200, but everywhere