Skip to content

Conversation

@nicorikken
Copy link
Contributor

A basic Asciidoctor plugin, which also features the ability to generate diagrams (PlantUML) and parse basic metadata from the adoc file.

THIS PLUGIN USES A FILE-BASED CONTENT TRANSPORT RATHER THAN A METADATA WAY. It is therefore not (yet) fully compatible with the other Perun modules.

This plugin adds the Asciidoctor functionality by including a Jruby Asciidoctor implementation. The resulting content is provided to the render stage using files rather than a string in the metadata. This was done to cope with string size limitations on the metadata, which was a constraint for the use-case this plugin was designed for. This plugin can be improved by adding support for metadata-based content handing, adding an Asciidoctor attribute parser, and further separating dependencies by wrapping it in a separate pod.

@podviaznikov
Copy link
Member

@nicorikken thanks for the PR. I need at least several days to follow up on this

@podviaznikov
Copy link
Member

@nicorikken boot has no problem any more with large metadata, so you can use regular way to pass metadata.
Do you want to update this PR with master code or you want me to take it from here?

@martinklepsch
Copy link
Contributor

boot has no problem any more with large metadata, so you can use regular way to pass metadata.

@podviaznikov by that you mean using boot.pod/send! right? :)

@podviaznikov
Copy link
Member

@martinklepsch yes, I think so

@nicorikken
Copy link
Contributor Author

I think it's fair to say this PR is soon to be replaced by PR #100 which uses the power of AsciidoctorJ's JRuby wrapper, instead of a DIY solution. I'd still have to get the libraries like asciidoctor-diagram to work however.

@martinklepsch martinklepsch mentioned this pull request Nov 26, 2016
@runnabot
Copy link

runnabot commented Jan 25, 2017

Deployed /master. View on Runnable.
From Runnable

@nicorikken
Copy link
Contributor Author

nicorikken commented Apr 27, 2017

Superseded by #100 (based on Asciidoctorj instead of a raw JRuby container) and now #183 (more minimal Asciidoctorj implementation based on the more current Perun framework). Therefore can be closed.

@nicorikken nicorikken closed this Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants