1177 enhancement apiv2 importfile fix todos #1874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 21, 2026 14:47
…iv2-importfile-fix-todos' into 1177-enhancement-apiv2-importfile-fix-todos
There was a problem hiding this comment.
Pull request overview
This pull request enhances the API v2 import file functionality by implementing proper TUS (Tus Upload Protocol) file handling with dedicated storage directories and cleaning mechanisms. The changes address TODO items and improve error handling in the file upload process.
Changes:
- Adds TUS directory configuration with dedicated subdirectories for uploads and metadata
- Implements file cleaning functionality to remove expired uploads
- Consolidates multiple cleaning operations into a unified cleaning mechanism
- Enhances error handling for file upload operations and metadata validation
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| src/inc/defines/global.php | Renames DZaps to DCleaning and consolidates cleaning constants; adds TUS directory constant |
| src/inc/confv2.php | Adds TUS directory path configuration with environment variable support |
| src/inc/startup/setup.php | Adds TUS directory validation and defines APP_NAME based on configuration |
| src/inc/apiv2/helper/importFile.routes.php | Implements TUS protocol endpoints with error handling, adds validation for metadata and file operations |
| src/inc/Util.class.php | Consolidates cleaning operations and adds tusFileCleaning function |
| src/inc/api/APISendProgress.class.php | Replaces separate cleaning calls with unified cleaning function |
| Dockerfile | Adds TUS directory structure with proper permissions |
| docker-entrypoint.sh | Refactors directory creation using array loop for better maintainability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1177