Skip to content

Update version bounds for GHC 7.8#6

Closed
bennofs wants to merge 1 commit into
haskell-hvr:masterfrom
bennofs:master
Closed

Update version bounds for GHC 7.8#6
bennofs wants to merge 1 commit into
haskell-hvr:masterfrom
bennofs:master

Conversation

@bennofs
Copy link
Copy Markdown

@bennofs bennofs commented Mar 7, 2014

I bounced the version bound for base to < 5, as it will cause issues with every new
ghc version and the package doesn't use any exotic functions from base. I removed the
upper bound on template-haskell, because it never makes sense to install a different
version of template haskell than the one provided by GHC.

@hvr
Copy link
Copy Markdown
Collaborator

hvr commented Mar 7, 2014

Tbh, I'd like to phase out deepseq-th in favor of deepseq-generics which I regard a much better approach to the problem it tries to solve. I regard this package obsolete.

Is there something which you can only do with deepseq-th?

@bennofs
Copy link
Copy Markdown
Author

bennofs commented Mar 7, 2014

Not really, I could just switch to deepseq-generics.

@hvr hvr closed this Mar 7, 2014
@hvr
Copy link
Copy Markdown
Collaborator

hvr commented Mar 7, 2014

ok; fwiw, deepseq-generics also is more reliable

@maxcan
Copy link
Copy Markdown

maxcan commented Apr 9, 2014

Making the switch over now. But, doesn't deepseq-generics impose a runtime penalty that deepseq-th would impose at compile time?

@hvr
Copy link
Copy Markdown
Collaborator

hvr commented Apr 10, 2014

@maxcan that's the cool thing about deepseq-generics: The GHC optimizer is clever enough so that the resulting code is as good as the one resulting by TH (if not even better in some cases I didn't handle in the TH code).

If you happen to find cases where this is not the case, it's a bug in the GHC optimizer. So you won't be able to measure a runtime penalty, but if you do, please file a bug, as that's most likely a bug in GHC then.

@hvr hvr mentioned this pull request May 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants