Fix mistake in BuildInfo.Lens.hs

[andreabedini]

  cxxSources f s = fmap (\x -> s{T.cSources = x}) (f (T.cxxSources s))

should be

  cxxSources f s = fmap (\x -> s{T.cxxSources = x}) (f (T.cxxSources s))

[ffaf1]

Template missing.

commit: fc3dc42
How is it possible that this was never spotted in almost eight years? Does nobody use lenses? Do we need to add some tests?

[andreabedini]

Template missing.

Guilty as charged. For a change this obvious and small, the mental effort required to process the template was higher than the one required to fix the bug. I mean no disrespect though.

[ffaf1]

No worries. This needs a changelog, does it not?

[Mikolaj]

Yes, this does not look like an obvious exception from the changelog rule. But well spotted!

[Mikolaj]

@andreabedini: a humble ping?

[ulysses4ever]

Good modulo draft state of the changelog, which I proposed how to fix.

[geekosaur]

Should we fast-track this just to get us to the 3.16 finish line faster?

[ulysses4ever]

yes

[zlonast]

@andreabedini I think it's time to rebase and add the merge me label :)

[geekosaur]

Also it occurs to me that nobody noticed (cf. #10609 (review)) because of #7072 and in general considerable confusion about cc-options vs. cxx-options that have only relatively recently been fixed, which would have masked it.

[geekosaur]

@Mikolaj, can you re-review or at least dismiss your changes-requested now that the changelog entry has been added?

[Mikolaj]

Thank you very much!

[zlonast]

@mergify rebase

[mergify]

rebase

❌ Command disallowed due to command restrictions in the Mergify configuration.

Details

• any of:
  • sender = {{author}}
  • sender-permission >= write