More tests for convenience libraries and some bugfixes (#3257)#3264
Closed
ezyang wants to merge 6 commits intohaskell:masterfrom
Closed
More tests for convenience libraries and some bugfixes (#3257)#3264ezyang wants to merge 6 commits intohaskell:masterfrom
ezyang wants to merge 6 commits intohaskell:masterfrom
Conversation
This are currently failing because there are bugs which need to be fixed. Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
This comment is not yet implemented, will be the subject of later patches. Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
Convenience libraries can have dependencies declared using build-depends. Unfortunately, these dependencies are special: in particular, the version range is meaningless because they always refer to the same package they were specified in. So, this infelicity means that the solver has to explicitly filter out these internal dependencies. I also had to fix validation to ignore these internal dependencies as well. Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
It needs to be done afterwards, because we need to compute the ABI hash as part of registration, which can't be done unless all dependencies are registered, which could include internal libraries. This whole affair is very dodgy. Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
Member
|
/cc @kosmikus |
| -- There are two things to note: | ||
| -- | ||
| -- 1. First, we eliminated the "local" dependencies foo-internal | ||
| -- and foo-helper. This are implicitly assumed to refer to "foo" |
Member
|
LGTM. BTW, can you add a note about convenience libraries to the changelog? |
Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.