Skip to content

A terrible hack which solves #3545.#3557

Closed
ezyang wants to merge 1 commit intohaskell:masterfrom
ezyang:pr/T3545
Closed

A terrible hack which solves #3545.#3557
ezyang wants to merge 1 commit intohaskell:masterfrom
ezyang:pr/T3545

Conversation

@ezyang
Copy link
Copy Markdown
Contributor

@ezyang ezyang commented Jul 15, 2016

See the comment in the code. I don't like it but it's BC!

Signed-off-by: Edward Z. Yang ezyang@cs.stanford.edu

See the comment in the code.  I don't like it but it's BC!

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
@mention-bot
Copy link
Copy Markdown

@ezyang, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ian-ross, @dcoutts and @SyntaxPolice to be potential reviewers

@ezyang
Copy link
Copy Markdown
Contributor Author

ezyang commented Jul 16, 2016

@23Skidoo @phadej What do you think?

@phadej
Copy link
Copy Markdown
Collaborator

phadej commented Jul 16, 2016

I don't think that re-arranging dist is breaking change as it's not clearly specified either. IIRC @dcoutts have commented about that somewhere.

Also e.g. https://github.com/ekmett/bound/blob/master/Setup.lhs doesn't rely on where stuff goes, as it asks Cabal where it puts stuff.

Also #3022 broke stuff already (for cabal_macros.h)


But if it helps for now, then LGTM


I'd propose to separate dist/build clearly per component, as we ultimately want to treat them fully independently apart that they come in single source package.

@23Skidoo
Copy link
Copy Markdown
Member

I'd prefer the solution originally proposed in #3545, i.e. rearranging the directories. Using dist/build for library files always felt wrong to me.

@ezyang
Copy link
Copy Markdown
Contributor Author

ezyang commented Jul 19, 2016

This change is vetoed!

@ezyang ezyang closed this Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants