Passes cxx options with using -optcxx flag.#6226
Closed
qnikst wants to merge 1 commit intohaskell:masterfrom
qnikst:cxx-opts
Closed
Passes cxx options with using -optcxx flag.#6226qnikst wants to merge 1 commit intohaskell:masterfrom qnikst:cxx-opts
qnikst wants to merge 1 commit intohaskell:masterfrom
qnikst:cxx-opts
Conversation
Recent GHC accepts CXX flags passed by optcxx, and this patch makes use of that feature.
Closed
|
Is it possible to get this merged, please? |
phadej
suggested changes
Jun 9, 2020
Collaborator
phadej
left a comment
phadej
left a comment
There was a problem hiding this comment.
See #6421 (comment)
Having tests for those cases (and what happens with older GHCs) will make it easier to merge this PR.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent GHC accepts CXX flags passed by optcxx, and this patch
makes use of that feature.
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!