Skip to content

Adapt to simplified subsumption patch#6563

Merged
phadej merged 1 commit intohaskell:masterfrom
phadej:simplified-subsumption-ryan
Mar 4, 2020
Merged

Adapt to simplified subsumption patch#6563
phadej merged 1 commit intohaskell:masterfrom
phadej:simplified-subsumption-ryan

Conversation

@phadej
Copy link
Copy Markdown
Collaborator

@phadej phadej commented Feb 29, 2020

Originally written by Ryan Scott in
#6545 (comment)

withTempDirectory verbosity targetDir template f = withFrozenCallStack $
withTempDirectoryEx verbosity defaultTempFileOptions targetDir template
(withLexicalCallStack f)
(withLexicalCallStack (\x -> f x))
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RyanGlScott I'll leave this in place, yet I'm not sure whether we need (i.e. there's any benefit) from wthFrozen/LexicalCallStack.

@phadej phadej force-pushed the simplified-subsumption-ryan branch from 87737d3 to 8dc7f0d Compare March 4, 2020 18:11
@phadej phadej merged commit c0dc305 into haskell:master Mar 4, 2020
@phadej
Copy link
Copy Markdown
Collaborator Author

phadej commented Mar 4, 2020

Merged. Ping @bgamari

@phadej phadej deleted the simplified-subsumption-ryan branch March 4, 2020 19:43
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 10, 2020
@phadej phadej mentioned this pull request Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants