Skip to content

Add Described to IndexState (incl. tests).#6591

Merged
phadej merged 1 commit intohaskell:masterfrom
phadej:index-state-tests
Mar 16, 2020
Merged

Add Described to IndexState (incl. tests).#6591
phadej merged 1 commit intohaskell:masterfrom
phadej:index-state-tests

Conversation

@phadej
Copy link
Copy Markdown
Collaborator

@phadej phadej commented Mar 16, 2020

  • Writing a regex to parse dates is awful.
  • Add ShortText conversions to PackageName and UnqualComponentName
  • Add mkDependency, which maintains the invariant
  • Remove VersionRangeParens - it's not preserved by parsec . pretty roundtrip
  • Move moree instances into Cabal-quickcheck,use the package in cabal-install tests

- Writing a regex to parse dates is awful.
- Add ShortText conversions to PackageName and UnqualComponentName
- Add mkDependency, which maintains the invariant
- Remove VersionRangeParens - it's not preserved by parsec . pretty
  roundtrip
- Move moree instances into Cabal-quickcheck,
  use the package in cabal-install tests
@phadej phadej merged commit b71d3db into haskell:master Mar 16, 2020
@phadej phadej deleted the index-state-tests branch March 16, 2020 21:55
@phadej phadej mentioned this pull request Jul 10, 2020
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant