Default to cabal version 2.4 when running cabal init.#6607
Merged
m-renaud merged 1 commit intohaskell:masterfrom Apr 1, 2020
Merged
Default to cabal version 2.4 when running cabal init.#6607m-renaud merged 1 commit intohaskell:masterfrom
m-renaud merged 1 commit intohaskell:masterfrom
Conversation
Cabal version 2.4 is over 2 years old at this point and has numerous additions compared to the current default 1.10.
Contributor
Author
|
Hmm, not sure why one of the CI checks failed (was cancelled) :/ This PR should be safe to merge since it only changes a value within the |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cabal version 2.4 is over 2 years old at this point and has numerous additions
compared to the current default 1.10.
There are numerous references to the
^>=operator throughout the docs (nix-local-build.rst and developing-packages.rst) but this does not work in version 1.10. This results in unnecessary confusion for users which then must manually edit the cabal file to change the version. To add to the confusion, the format written to the cabal file (cabal-version: >=1.10) only works for this version, to use a newer version you need to remove the>=which is undocumented and confusing.Lets just default to a more recent version.
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!