Mention password-command option in upload --help#6609
Closed
v0d1ch wants to merge 1 commit intohaskell:masterfrom
Closed
Mention password-command option in upload --help#6609v0d1ch wants to merge 1 commit intohaskell:masterfrom
v0d1ch wants to merge 1 commit intohaskell:masterfrom
Conversation
phadej
suggested changes
Mar 23, 2020
Collaborator
phadej
left a comment
phadej
left a comment
There was a problem hiding this comment.
I don't understand the commit message.
Should, why?
Contributor
Author
|
I copy pasted the issue title there. I can update it if you want. I didn't bother in the first place since the change is very trivial. |
Collaborator
|
The commit message should explain why the change is made. I don't understand it. Neither there is reference to the issue. |
v0d1ch
force-pushed
the
5224-cabal-config-should-have-field-for-password-command
branch
from
9028661 to
eff17be
Compare
Contributor
Author
|
Oh I just realized this work has already been done here #6313. |
v0d1ch
changed the title
v0d1ch
force-pushed
the
5224-cabal-config-should-have-field-for-password-command
branch
from
eff17be to
9d621a6
Compare
v0d1ch
force-pushed
the
5224-cabal-config-should-have-field-for-password-command
branch
from
9d621a6 to
c78ab2d
Compare
Contributor
Author
|
@phadej should we close this one? |
Collaborator
|
We should merge this, but I still need to check something. Sorry for forgetting this one for a while. |
Collaborator
|
Merged in #6680 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.