4267 Add --exact flag to the list command#6618
Closed
v0d1ch wants to merge 1 commit intohaskell:masterfrom
Closed
Conversation
phadej
suggested changes
Mar 27, 2020
v0d1ch
force-pushed
the
4267-cabal-list-exact-option
branch
from
a47b0e3 to
b6cdb56
Compare
Contributor
Author
|
Pinging Dr. @phadej again |
v0d1ch
force-pushed
the
4267-cabal-list-exact-option
branch
from
b6cdb56 to
1bf4be6
Compare
phadej
reviewed
Apr 6, 2020
| -*-change-log-*- | ||
|
|
||
| 3.2.0.0 Herbert Valerio Riedel <hvr@gnu.org> April 2020 | ||
| 3.2.0.0 Someone <mailto:somewhere@example.com> February 2020 |
Collaborator
There was a problem hiding this comment.
Add fine to changelog.d directory, see the issue-* files for an examples
It's recent change, so we won't introduce conflicts to changelog files.
| then do | ||
| putStrLn $ "Obtaining the package list (using " ++ argCabal1 ++ ") ..." | ||
| list <- readProcess argCabal1 ["list", "--simple-output"] "" | ||
| list <- readProcess argCabal1 ["list", "--simple-output", "--exact"] "" |
Collaborator
There was a problem hiding this comment.
This doesn't seem to be related to the reported issue. Why this change? Does exact makes it somehow faster?
| | pkgs@(pname, _) <- Map.toList m | ||
| , lsearchterm `isInfixOf` lowercase (unPackageName pname) ] | ||
| , if exactMatch | ||
| then searchterm `isInfixOf` unPackageName pname |
This PR adds `--exact` flag to the cabal list command which enables exact match on the package name while searching.
v0d1ch
force-pushed
the
4267-cabal-list-exact-option
branch
from
1bf4be6 to
3d44fef
Compare
Collaborator
|
Merged in #6681. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4267
This PR adds
--exactflag to the cabal list command whichenables exact match on the package name while searching.
The cabal list output looks like this for
mtlpackage:And when using the
--exactflag we are matching the exact package name like this: