Split the monolithic Init.hs module into 5 sub-modules.#6641
Closed
m-renaud wants to merge 1 commit intohaskell:masterfrom
Closed
Split the monolithic Init.hs module into 5 sub-modules.#6641m-renaud wants to merge 1 commit intohaskell:masterfrom
m-renaud wants to merge 1 commit intohaskell:masterfrom
Conversation
Contributor
Author
|
FYI @phadej previous PR was automatically closed when I reset the branch to fix the merge conflict. Was easier just to create a new branch and PR. |
Contributor
Author
|
Huh, interesting CI failures:
😕 |
Contributor
Author
|
Looks like it may be caused by a race condition in GitHub actions: actions/checkout#23 |
Collaborator
|
@m-renaud try to force push, that should fix that. Thanks for upstream reference. |
Init.Command - Main cabal init logic that ties everything together. Init.Defaults - Default values for items not specified in config or arguments Init.FileCreators - All the createXyz functions which write files (LICENSE, Main.hs, etc.) Init.Prompt - Utilities for prompting the user for selections Init.Utils - Misc utilities shared across the above modules
m-renaud
force-pushed
the
restructure-init
branch
from
7cc09a4 to
8c862cc
Compare
Contributor
Author
|
Sigh, looks like a lot of the checks are hanging now.. |
Collaborator
|
I restarted linux jobs, will merge if they are green. |
Contributor
Author
|
Closing this PR since it was merged in #6650. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Init.Command - Main cabal init logic that ties everything together.
Init.Defaults - Default values for items not specified in config or arguments
Init.FileCreators - All the createXyz functions which write files (LICENSE, Main.hs, etc.)
Init.Prompt - Utilities for prompting the user for selections
Init.Utils - Misc utilities shared across the above modules
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!