Merged
Conversation
phadej
force-pushed
the
init-improvements
branch
from
0c8a9eb to
c914dde
Compare
m-renaud
suggested changes
Apr 6, 2020
Contributor
m-renaud
left a comment
m-renaud
left a comment
There was a problem hiding this comment.
Overall LGTM, thanks for the cleanups!
phadej
force-pushed
the
init-improvements
branch
from
c914dde to
0d605da
Compare
- Always ask for SPDX expression, we can "convert" them to old format - No default license - Add cabal-version: 3.0 to the list - cabal-version is asked using CabalSpecVersion type - seems to fix what haskell#6619 tries to fix: ``` % /code/shared-haskell/cabal/dist-newstyle/build/x86_64-linux/ghc-8.8.3/cabal-install-3.3.0.0/x/cabal/build/cabal/cabal init -l 'FOO AND BAR' Cannot parse license: FOO AND BAR CallStack (from HasCallStack): error, called at ./Distribution/ReadE.hs:42:24 in Cabal-3.3.0.0-inplace:Distribution.ReadE ``` an error, but it doesn't loop.
phadej
force-pushed
the
init-improvements
branch
from
0d605da to
738a333
Compare
m-renaud
approved these changes
Apr 6, 2020
Contributor
m-renaud
left a comment
m-renaud
left a comment
There was a problem hiding this comment.
LG, feel free to merge whenever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ping @m-renaud