Skip to content

Described Mixin#6800

Merged
phadej merged 1 commit intohaskell:masterfrom
phadej:mixin-described
May 14, 2020
Merged

Described Mixin#6800
phadej merged 1 commit intohaskell:masterfrom
phadej:mixin-described

Conversation

@phadej
Copy link
Copy Markdown
Collaborator

@phadej phadej commented May 14, 2020

Related to #6281

Screenshot from 2020-05-14 20-29-27

(black dots are where space is required).

@phadej phadej force-pushed the mixin-described branch from c43c8fa to 7898f52 Compare May 14, 2020 17:31
@phadej phadej merged commit 9c148f7 into haskell:master May 14, 2020
@phadej phadej deleted the mixin-described branch May 14, 2020 19:09
@phadej
Copy link
Copy Markdown
Collaborator Author

phadej commented May 14, 2020

I think

mixins: pkg(Module)requires(Module2)

is accepted by the parser but not precisely Described. The whitespace is tricky when we have infix keywords and empty productions. E.g.

mixins: pkg requires(Module2 as Module3)
mixins: pkg requires hiding{Module4}

@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 10, 2020
@phadej phadej mentioned this pull request Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant