Make cabal-install compilable with NoImplicitPrelude#6818
Merged
phadej merged 1 commit intohaskell:masterfrom May 19, 2020
Merged
Make cabal-install compilable with NoImplicitPrelude#6818phadej merged 1 commit intohaskell:masterfrom
phadej merged 1 commit intohaskell:masterfrom
Conversation
phadej
force-pushed
the
use-prelude-in-cli
branch
4 times, most recently
from
2b44384 to
c6ac63d
Compare
I.e. find out where we don't yet used `Distribution.Client.Compat.Prelude`. - If the module is small I added direct `Prelude` imports. - Add Exception, deepseq stuff to Cabal Prelude - Add Parsec, Pretty and Verbosity to Client Prelude - use for, for_, traverse and traverse_ (removes need for Control.Monad)
phadej
force-pushed
the
use-prelude-in-cli
branch
from
c6ac63d to
d4fd273
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I.e. find out where we don't yet
used
Distribution.Client.Compat.Prelude.Preludeimports.