don't auto-download in hash validation phase #8769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
@jneira will be unamused. |
Member
|
well, let's register the debt with a label 😉 |
ulysses4ever
approved these changes
Feb 15, 2023
Collaborator
ulysses4ever
left a comment
ulysses4ever
left a comment
There was a problem hiding this comment.
A test would be nice but the regression is pretty bad, and the earlier we merge a fix the better.
Member
|
@mergify backport 3.10 |
Contributor
✅ Backports have been createdDetails
|
Member
|
Let me set the label and the backport in the interest of swiftness. We still have 2 days to add a test. |
mergify
bot
added
the
merge delay passed
gbaz
force-pushed
the
gb/validate-no-download
branch
from
8bd9f68 to
5497325
Compare
mergify bot
added a commit
that referenced
this pull request
Feb 17, 2023
don't auto-download in hash validation phase (backport #8769)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8708 and #8706
Sorry, no additional regression test for this.