Find build-tool installed programs before programs in path #9762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@gbaz here is the fix. It still needs a test, I'm trying to figure out how to do one for this specifically. Happy to take any ideas |
Collaborator
Author
|
(BTW I've tested this locally on Andreas' reproducer successfully) |
alt-romes
force-pushed
the
wip/romes/9756
branch
from
384c30e to
9fb5ff2
Compare
geekosaur
requested changes
Mar 1, 2024
geekosaur
approved these changes
Mar 1, 2024
alt-romes
force-pushed
the
wip/romes/9756
branch
2 times, most recently
from
e710313 to
12c2bdd
Compare
Collaborator
Author
|
Test added, ready to merge. |
Collaborator
Author
Collaborator
|
Thank you so much for moving quickly on this. Given how quickly this has been done, and that the only key change is line 1239 of configure.hs, I definitely think we should backport. |
gbaz
approved these changes
Mar 1, 2024
ulysses4ever
added
attention: needs-backport 3.10
and removed
attention: needs-review
labels
alt-romes
force-pushed
the
wip/romes/9756
branch
from
12c2bdd to
443c890
Compare
Collaborator
Author
|
I've added the comment you requested @gbaz. I'm also going to put forward a backport MR |
geekosaur
approved these changes
Mar 1, 2024
mergify
bot
added
the
merge delay passed
We must consider the path to the installed build-tool before the path to existing versions of the build tool in paths such as `extra-prog-path` or in the system path. This was previously fixed by haskell#8972 but undone by haskell#9527. This also renames `appendProgramSearchPath` to `prependProgramSearchPath` to describe correctly what that function does. Fixes haskell#9756
Member
|
@backport 3.12 |
Member
|
@mergify backport 3.12 |
Contributor
✅ Backports have been createdDetails
|
Member
|
@backport --- apologies, wrong ping, but you must be used to it by now, aren't you? :) |
mergify bot
added a commit
that referenced
this pull request
Mar 4, 2024
Find build-tool installed programs before programs in path (backport #9762)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must consider the path to the installed build-tool before the path to existing versions of the build tool in paths such as
extra-prog-pathor in the system path.This was previously fixed by #8972 but undone by #9527.
This also renames
appendProgramSearchPathtoprependProgramSearchPathto describe correctly what that function does.Fixes #9756