escape: remove too agressive JSON escaping#248
Merged
RyanGlScott merged 1 commit intohaskell:masterfrom Dec 8, 2021
Merged
Conversation
RyanGlScott
reviewed
Dec 6, 2021
Member
RyanGlScott
left a comment
RyanGlScott
left a comment
There was a problem hiding this comment.
Thanks so much, @considerate!
considerate
force-pushed
the
considerate/escape-codes
branch
from
4f792c6 to
f346066
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the overzealous "for good measure" escape of the JSON data that caused issues when using quotes in the benchmark names.
Closes #235