Use Hackage fixities in Fourmolu CLI mode #3454
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgefst
commented
Jan 17, 2023
| getUnit = \case | ||
| ExposePackage _ (UnitIdArg (RealUnit (Definite (UnitId s)))) _ -> Just s | ||
| _ -> Nothing | ||
| drop' n xs = drop (n `min` (Prelude.length xs - 1)) xs |
Collaborator
Author
There was a problem hiding this comment.
This is a horrible hack, but I don't have any better ideas. I wouldn't be surprised if there's no clean way to go from GHC package-id strings to Hackage library names.
Collaborator
|
Can we somehow instead pass the actual accurate fixities that GHC computes for the file to fourmolu? It seems strange to rely on hacks when in HLS we know the actual fixities for everything as soon as a file compiles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3421.
Could do with a test.
(EDIT: I've forgotten exactly how this relates to #3165...)
(EDIT: I'm also now confused as to why I wanted to pass
--no-cabalin the first place in #2950 (sub-EDIT ah, probably just performance). We should also look at #3449 and #3771 and see whether Ormolu has similar issues.)