Revert "Support fourmolu 0.13.0.0" #3661
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c126332.
Collaborator
Author
|
@brandonchinn178 If you still want to support fourmolu 0.13 make a new pull request that incorporates adaptions to the breaking changes from fourmolu 0.13. One of the breaking changes is it no longer exports FixityMap, but there could be others. I would recommend you force cabal to build with 0.13, by temporarily removing the other version options. That way you can make sure it compiles with 0.13. |
Contributor
|
Yes, I'll fix, sorry about that. To prevent this in the future, perhaps CI could run Cabal, to test against the latest version of all packages? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3631 . When fourmolu actually ends up being built with 0.13.0.0 it fails to compile, as the API has changed.