Skip to content

Fix semigroupLaws tests#329

Merged
andrewthad merged 1 commit intohaskell:masterfrom
konsumlamm:semigroup-laws
Mar 24, 2022
Merged

Fix semigroupLaws tests#329
andrewthad merged 1 commit intohaskell:masterfrom
konsumlamm:semigroup-laws

Conversation

@konsumlamm
Copy link
Copy Markdown
Contributor

Followup to #326.

The test suite would previously fail on 7.10, because I forgot to put the semigroupLaws test inside a #if block (sorry).

konsumlamm added a commit to konsumlamm/primitive that referenced this pull request Dec 24, 2021
@konsumlamm konsumlamm mentioned this pull request Dec 24, 2021
@andrewthad
Copy link
Copy Markdown
Contributor

Can you confirm that this is good to be merged? I'm can't tell based on CI output, but I'll take your word if you say it works.

@konsumlamm
Copy link
Copy Markdown
Contributor Author

@andrewthad yeah, this is merely moving the semigroupLaws tests inside an #if MIN_VERSION_base(4,9,0), as Semigroup was added in base-4.9.0.0. I'm not sure what exactly is causing the CI failure (see #322).

@andrewthad andrewthad merged commit 8d54825 into haskell:master Mar 24, 2022
@konsumlamm konsumlamm deleted the semigroup-laws branch March 24, 2022 13:18
konsumlamm added a commit to konsumlamm/primitive that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants