Correctly detect posix_spawn_file_actions_addchdir[_np] #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l#303) It appears that CPP macro names are case sensitive, and the code was previously checking for HAVE_posix_spawn_file_actions_addchdir whereas Autoconf defines HAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR. This meant that calls to createProcess which set cwd to a Just value would always fail to use posix_spawn and instead fall back on fork, which is problematic when the parent process has a large residency. Testing the fix revealed another issue, which is that _GNU_SOURCE must be defined before any glibc headers are included, otherwise the _np variant provided by glibc will not be declared.
Contributor
|
Oof, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #303. The previous fix in #304 unfortunately didn't resolve the issue, but I've tested with
stracethat this patch results in the right syscall.It appears that CPP macro names are case sensitive, and the code was previously checking for
HAVE_posix_spawn_file_actions_addchdirwhereas Autoconf definesHAVE_POSIX_SPAWN_FILE_ACTIONS_ADDCHDIR. This meant that calls tocreateProcesswhich setcwdto aJustvalue would always fail to useposix_spawnand instead fall back onfork, which is problematic when the parent process has a large residency.Testing the fix revealed another issue, which is that
_GNU_SOURCEmust be defined before any glibc headers are included, otherwise the_npvariant provided by glibc will not be declared.