Skip to content

Conversation

@Bodigrim
Copy link
Contributor

As discussed in #164.

@chessai
Copy link
Member

chessai commented Feb 13, 2021

LGTM

@vdukhovni
Copy link
Contributor

Looking at the resulting files, I still find a few #if conditionals on outdated GHC versions:

System/Posix/Signals.hsc:#if defined(darwin_HOST_OS) && __GLASGOW_HASKELL__ < 706
System/Posix/Terminal.hsc:# if __GLASGOW_HASKELL__ < 800
System/Posix/Terminal.hsc:# if __GLASGOW_HASKELL__ < 800
System/Posix/Terminal/ByteString.hsc:# if __GLASGOW_HASKELL__ < 800
System/Posix/Terminal/ByteString.hsc:# if __GLASGOW_HASKELL__ < 800
cbits/HsUnix.c:#if HAVE_PTSNAME && (__GLASGOW_HASKELL__ < 800)

Perhaps tidy these up also?

Copy link
Contributor

@vdukhovni vdukhovni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@hs-viktor
Copy link
Contributor

FWIW, I'm inclined to just push "Rebase and merge" without waiting for Emily, but I'm not doing it, because we haven't established proper protocol for this, so I don't know whether that'd be OK, or bad karma. Which is it?

@chessai
Copy link
Member

chessai commented Feb 13, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants