Fix the error handling of posix_fallocate #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdukhovni
reviewed
Apr 17, 2022
matil019
changed the title
Contributor
|
CI failed, but I just merged a CI fix PR. Perhaps rebasing will resolve the issue. Please rebase. |
This commit introduces a CPP guard to take care of the difference between OSes of the errors of posix_fallocate. On Linux and NetBSD, posix_fallocate reports error by returning an error number. errno is not set. On the other hand, on FreeBSD, posix_fallocate returns -1 and sets errno. The existing code could handle FreeBSD-style errors only.
The FreeBSD-style error (return -1, set errno) is obsolete as of FreeBSD 11.0; it now reports errors as same as the other OSes.
matil019
force-pushed
the
fileallocate-error
branch
from
bc10aec to
e8dda97
Compare
Contributor
Author
|
Rebased. |
Contributor
|
Forgot about the haskell.org outage, will have to retry the CI later... |
Contributor
|
CI is all green. |
Bodigrim
approved these changes
Apr 19, 2022
hs-viktor
approved these changes
Apr 19, 2022
This was referenced Jul 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #156
This commit introduces a CPP guard to take care of the difference between OSes of the errors ofposix_fallocate.Update: No conditionals are added, just the error handler is updated to correctly handle the error value returned by
posix_fallocate.