Skip to content

Conversation

@TerrorJack
Copy link
Contributor

This PR is a predecessor to #205. We shall no longer deny building for platforms lacking dlfcn.h, but rely on fine-grained checks on individual interfaces instead.

@Bodigrim Bodigrim requested a review from hs-viktor May 4, 2022 17:49
@TerrorJack
Copy link
Contributor Author

Hi, would you take another look at this PR? The aarch64 CI failure is irrelevant and seem to be random timeout, shouldn't be a problem if the 60min limit is bumped a bit.

@hs-viktor
Copy link
Contributor

I am not sure why this makes sense as a stand-alone PR. The dlfcn.h header is still included in HsUnix.h, so the unix package won't build if it is missing without further changes. Why not make this change in a PR that actually makes unix not unconditionally depend on dlfcn.h.

@TerrorJack
Copy link
Contributor Author

And that PR would be #205. @Bodigrim indeed the changes here are too small to be meaningful, would you agree on closing this one and getting back to #205 once the ghc warnings are fixed there?

@Bodigrim
Copy link
Contributor

@TerrorJack no problem.

@TerrorJack TerrorJack closed this May 12, 2022
@TerrorJack TerrorJack deleted the no-check-buildable branch May 12, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants