Skip to content
This repository was archived by the owner on Mar 26, 2025. It is now read-only.

Conversation

@mrkaye97
Copy link
Contributor

@mrkaye97 mrkaye97 commented Jan 13, 2025

Overhauling the client config to use Pydantic to get rid of a lot of convoluted parsing + validation code.

Main things here:

  • Got rid of the config.yaml stuff since nobody seems to be using that and it makes the code paths significantly more complicated.
  • Strict typing for all of the fields with the same defaults + field validators in the cases where there's parsing logic like extracting something from the JWT
  • God rid of the ConfigLoader, since now we can instantiate the class directly
  • Enabled mypy for the new config class now that types check out

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants