Page turner dependency updates

[carylwyatt]

Suspiciously, the upgrade to vite 6 worked out of the box. I tweaked the config a bit to match the changes I made for firebird, but other than that, it seems fine. All the security vulnerability messages are gone.

I updated playwright and updated the playwright docker service to match the updated version. Some of my local tests failed because of imgsrv giving me "Forbidden" 403 errors, but that happens to me locally sometimes. I'll wait and see if it passes here.

I want to test this on dev-3 before merging into main, but I have the pt error handling stuff staged there at the moment. I'll get the two branches merged on dev-3 shortly and update this. Update: tested on dev-3 and it looks great!

Edit to add: I went ahead and updated to vite 7. Tests passed and the build on dev-3 looks good! I will wait on updating to vite 8 since there are some significant changes, but maybe it will not be so bad. I'll try it out during the next dependency update Monday!

[aelkiss]

Looks great.

There was something we had to do in firebird-common with vite to generate the css file with the expected name, but IIRC you thought there might be another option for handling that in vite 6. It doesn't look like we had a similar issue here in pageturner though, and firebird is still on vite 5? https://github.com/hathitrust/firebird-common/blob/main/vite.config.js#L38

[carylwyatt]

There was something we had to do in firebird-common with vite to generate the css file with the expected name, but IIRC you thought there might be another option for handling that in vite 6. It doesn't look like we had a similar issue here in pageturner though, and firebird is still on vite 5? https://github.com/hathitrust/firebird-common/blob/main/vite.config.js#L38

@aelkiss When I upgraded firebird to vite 6, I hoped I could get rid of the custom plugins that re-write the manifest asset file names, but that didn't end up happening. I made a small change to the asset name plugin here in page turner (similar to the change I did in firebird when upgrading to vite 6), but other than that, there are no other changes. I looked at the breaking changes list in the release notes for vite 7 to make sure our build wouldn't break, but I didn't look in to new features to see if/how the config could be refined.

Firebird's vite config is much more complicated thanks to storybook, so this was a simple upgrade in comparison.

[carylwyatt]

@aelkiss Well, I take that back. I deleted the custom plugin and the dist folder, and pt/vite built the asset files just fine without it. I'll push a new commit with the updated config and test it on dev-3!

[carylwyatt]

I tested the updated config on dev-3, and everything looks great.
I also went looking for info on the bootstrap/node-sass situation since that's another ugly workaround, and they did migrate to Sass modules... in version 6, which hasn't been released and has no release date in sight.