Changing :alpha: and :alnum: to char properties#31
Open
Cladis wants to merge 1 commit intohatnote:masterfrom
Open
Changing :alpha: and :alnum: to char properties#31Cladis wants to merge 1 commit intohatnote:masterfrom
Cladis wants to merge 1 commit intohatnote:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks that although the matching regex in hashtags/utils.py support all unicode the SQL, regexes here do not and only
[A-Za-z][A-Za-z0-9]hashtags are this supported by the tool. This attempts to fix it using Unicode character properties as per https://mariadb.com/kb/en/library/pcre/ . Support for this is since MariaDB 10.0.5, so 10.0.33 new replica servers should support it. Unfortunately I cannot test this though, ass52467__new_hashtagstable is not public.I was asked to figure out why https://tools.wmflabs.org/hashtags/search/спецпатруль?lang=uk request does not work. You can use it for testing the patch.