Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I only updated some classes that I have been working on in the previous PR.
However, actually repetitive/redundant code are quite widespread in the repo, not sure if it worth a fix though, especially when there are no unit tests exist.
Here are some examples:
varandfunctionare by default private unless explicitly declaredpublic, soprivate var xcan be simply written asvar xpublic override function: the accessor (public/private) can be omitted if it is unchanged vs the super one== trueis redundant and== falsecan be replaced by prefix!unless the bool value is nullable.cast(value, TheType). Note that safe casts have runtime performance impact. If the type are known at compile time, unsafe casts will be more suitablevar v:TheType = cast value