103. Binary Tree Zigzag Level Order Traversal#35
Open
hayashi-ay wants to merge 2 commits intomainfrom
Open
Conversation
nodchip
reviewed
Feb 27, 2024
| return [] | ||
| nodes = [root] | ||
| level = 0 | ||
| ans = [] |
There was a problem hiding this comment.
ans について、プログラム中で何を表しているかを表す単語にした方が良いと思います。自分なら order とつけますが、もう少し良い名前があるかもしれません。
Owner
Author
There was a problem hiding this comment.
ありがとうございます。命名サボってしまいました。
| node = nodes[i] | ||
| values.append(node.val) | ||
| first, second = access_orders[level % 2] | ||
| first_node = getattr(node, first) |
There was a problem hiding this comment.
リフレクション的な機能は極力使用しないほうが良いと思います。理由は、コンパイル時の静的な解析でエラーを特定することが難しくなる場合があるためです。
| nodes_ordered = [] | ||
| zigzag_order_nodes_by_level(root, 1) | ||
| # dequeのlistになっているのでlistに変換する | ||
| ans = [] |
There was a problem hiding this comment.
return [list(nodes) for nodes in nodes_ordered]
と掛けなくはないのですが、少し指しすぎかもしれません。
実際の現場においては、単純な内包表記であれば、読みやすさを考慮したうえで使用しても大丈夫だと思います。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/binary-tree-zigzag-level-order-traversal/