Open
Conversation
nodchip
reviewed
Mar 24, 2024
| ```python | ||
| class Solution: | ||
| def topKFrequent(self, nums: List[int], k: int) -> List[int]: | ||
| freq = defaultdict(int) |
There was a problem hiding this comment.
数字と頻度の辞書であることが分かりやすいよう、 num_to_freqencies といった名前にするとよいと思います。
| freq[sorted_index], freq[right] = freq[right], freq[sorted_index] | ||
| return sorted_index | ||
|
|
||
| def quick_select(freq, left, right, k): |
There was a problem hiding this comment.
個人的には開閉区間で扱うほうが一般的だと思います。実装上閉区間で扱ったほうが扱いやすいのであれば、その旨をソースコードで書くとよいと思います。
Owner
Author
There was a problem hiding this comment.
ありがとうございます。rangeとかも右側が開区間ですしね。書いてみましたが、そこまで実装の手間は変わらなかったです。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/top-k-frequent-elements/
#3 で解いているが解き直し