Open
Conversation
nodchip
reviewed
Mar 29, 2024
| ```python | ||
| class Solution: | ||
| def nextPermutation(self, nums: List[int]) -> None: | ||
| def first_decreasing_index_from_right(): |
There was a problem hiding this comment.
関数名は動詞で始めるとよいと思います。 find_first_decreasing_index_from_right または find_last_of_descreasing_num_index はいかがでしょうか？
| return i | ||
| return -1 | ||
|
|
||
| def next_number_index(begin, lower): |
There was a problem hiding this comment.
next_number_index ですと、次の数字インデックスを返しているように感じます。 find_minimum_number_index_larger_than はいかがでしょうか？
| index += 1 | ||
| return len(nums) - 1 | ||
|
|
||
| def swap_in_range(left, right): |
There was a problem hiding this comment.
swap_in_range ですと、何をスワップして、最終的にどのような状態にしようとしているのかが分かりにくく感じました。 reverse_in_range のままでよいと思います。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/next-permutation/