Skip to content

322. Coin Change#68

Open
hayashi-ay wants to merge 3 commits intomainfrom
hayashi-ay-patch-57
Open

322. Coin Change#68
hayashi-ay wants to merge 3 commits intomainfrom
hayashi-ay-patch-57

Conversation

@hayashi-ay
Copy link
Copy Markdown
Owner

```python
class Solution:
def coinChange(self, coins: List[int], amount: int) -> int:
num_need_coins = [inf] * (amount + 1)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need を形容詞的に使うのであれば needed とすると思います。

```python
class Solution:
def coinChange(self, coins: List[int], amount: int) -> int:
num_min_coins = [inf] * (amount + 1)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英語で書くと minimum number of coins だと思いますので、 min_num_coins が良いと思います。

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。
「number of minimum coins」としてnum_min_coinsにしたのですが英語として不自然みたいですね(ChatGPTに聞きました)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants