Gate engine template instantiations by PGen compatibility#4
Merged
haykh merged 4 commits intodev/emissionfrom Jan 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Enginetemplates for every entry inNTT_FOREACH_SPECIALIZATION, which triggered template constraint failures for engine/metric/dimension combinations that are incompatible with the selected problem generator (PGen).Description
src/engines/engine_init.cpp,src/engines/engine_run.cpp, andsrc/engines/engine_printer.cppby addingEngineInitInstantiator,EngineRunInstantiator, andEnginePrinterInstantiatorrespectively.if constexpr (IsCompatibleWithEngine<S, M<D>>)and takes the address of the corresponding member function (for example(void)&Engine<S, M<D>>::init) so the compiler only instantiates members for compatible combinations instead of all specializations.NTT_FOREACH_SPECIALIZATIONexpansion now emits unique static instantiator variables using__COUNTER__and smallNTT_CONCATmacros to avoid global template instantiations for incompatible combos, and related cleanup of macros was added.init,run, andprint_reportinstantiations byPGencompatibility, preventing the earlier compile-time constraint failures.Testing
Codex Task