Skip to content

keep.xml rules issues #314

@freszu

Description

@freszu

While using CCP library i ran into following issue related to current keep.xm config

  • When any consuming app creates it's own keep.xml file the one from library will be overridden this is actually mistake that is quite easy to make when following official guides which suggest such name : https://developer.android.com/studio/build/shrink-code and caused some crashes for me on some of the languages - the keep.xml could be renamed.
  • The rules included in the keep.xml include pretty much every raw file in consumer app. So once this library is included all raw files are kept (reproduced in sample: https://github.com/freszu/CCPKeepBug/) , so the rule should be narrowed down. Maybe it's a good idea to start each translation file with some prefix as a quick win.

Results from apk analyzer:
Without code picker dependency:
Screenshot 2019-05-28 at 16 20 00
With code picker dependency:
Screenshot 2019-05-28 at 16 20 58

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions