UBERF-13844,13845: Edit card type UI improvements#10009
Merged
Conversation
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
|
Connected to Huly®: UBERF-13849 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements UI improvements for card type editing by adding search functionality to dropdown lists and removing unnecessary confirmation dialogs. The changes enhance user experience by making dropdown selection more efficient and streamlining the enum editing workflow.
- Adds search capability to the DropdownLabelsPopupIntl component with keyboard navigation improvements
- Removes unnecessary confirmation dialog when closing enum editing without changes
- Enables search functionality in the RefEditor dropdown for class selection
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/ui/src/components/DropdownLabelsPopupIntl.svelte | Adds search input, filtering logic, and improved keyboard navigation |
| packages/ui/src/components/DropdownLabelsIntl.svelte | Passes withSearch prop to the popup component |
| plugins/setting-resources/src/components/typeEditors/RefEditor.svelte | Enables search functionality for class selection dropdown |
| plugins/setting-resources/src/components/EditEnum.svelte | Adds logic to skip confirmation dialog when enum values are unchanged |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
BykhovDenis
previously approved these changes
Oct 2, 2025
Signed-off-by: Alexey Zinoviev <alexey.zinoviev@xored.com>
BykhovDenis
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
Related to: https://front.hc.engineering/workbench/platform/tracker/UBERF-13844, https://front.hc.engineering/workbench/platform/tracker/UBERF-13845